-
Notifications
You must be signed in to change notification settings - Fork 2
[CLD-1032]: feat(engine): allow configuration for SUI chain in test engine #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SUI teams wants to be able to specify docker image used for the sui container. This commit exposes the provider configuration on the test engine layer. JIRA: https://smartcontract-it.atlassian.net/browse/CLD-1032
🦋 Changeset detectedLatest commit: 513ecce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for custom configuration of SUI chain containers in the test engine, allowing teams to specify docker images and other provider settings for SUI blockchain testing.
Changes:
- Exposed
SuiContainerConfigtype alias for provider configuration - Added
NewSuiContainerLoaderWithConfigfunction to create loaders with custom configuration - Introduced
WithSuiContainerWithConfigandWithSuiContainerNWithConfighelper functions for test environment setup
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| engine/test/onchain/sui.go | Added type alias and new loader function that accepts custom configuration |
| engine/test/onchain/sui_test.go | Added test for the new configuration-based loader function |
| engine/test/environment/options.go | Added helper functions to use custom SUI configuration in test environments |
| .changeset/fast-chefs-shop.md | Added changeset documentation for the feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - [#670](#670) [`0a320ef`](0a320ef) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - feat(engine): allow configuration for SUI chain in test engine ### Patch Changes - [#668](#668) [`ff9c85a`](ff9c85a) Thanks [@jkongie](https://github.com/jkongie)! - Bump `go-ethereum` to v1.16.8 --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>


SUI teams wants to be able to specify docker image used for the sui container. This commit exposes the provider configuration on the test engine layer.
JIRA: https://smartcontract-it.atlassian.net/browse/CLD-1032